Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all reconciles to fail if the health checker fails to start #8761

Closed
4 tasks
BlaineEXE opened this issue Sep 20, 2021 · 4 comments
Closed
4 tasks

Update all reconciles to fail if the health checker fails to start #8761

BlaineEXE opened this issue Sep 20, 2021 · 4 comments
Labels

Comments

@BlaineEXE
Copy link
Member

We should investigate taking the same approach from #8708 for all health checkers:

  • ceph status
    • special considerations:
      • We should not create a condition where Rook will not reconcile OSDs if the Ceph status is not HEALTH_OK because reconciling the OSDs may fix the health status in some cases
  • osd status
  • pool mirror
  • fs mirror

The CephObjectStore reconciler will fail the reconcile if the health checker fails to start. This is imperative for the object store because we use an HTTP API for the health check which can fail.

For other statuses, if the status check can fail, we should update the reconcile to ensure we only report a successful reconcile once we know we can start getting status reports.

See original discussion: #8708 (comment)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@BlaineEXE BlaineEXE removed the wontfix label Nov 30, 2021
@BlaineEXE BlaineEXE reopened this Nov 30, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant