Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add possibility to default filesystem storageclass in rook-ceph-cluster chart #8771

Merged
merged 3 commits into from Sep 21, 2021

Conversation

kubealex
Copy link
Contributor

Description of your changes:

I added isDefault field to helm chart to allow users to default filesystem StorageClass.

kubealex and others added 2 commits September 21, 2021 14:49
I Added the chance to default filesystem storageclass in helm chart

Signed-off-by: kubealex <al.rossi87@gmail.com>
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have this feature for the file storage class in the helm chart, similar to the block storage class.

cluster/charts/rook-ceph-cluster/values.yaml Outdated Show resolved Hide resolved
I fixed the placement of the modification, from object storage to filesystem

Signed-off-by: kubealex <al.rossi87@gmail.com>
Copy link
Contributor Author

@kubealex kubealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the review

@travisn travisn merged commit 6bcb569 into rook:master Sep 21, 2021
travisn added a commit that referenced this pull request Sep 22, 2021
ceph: Add default field to filesystem-sc helm chart (backport #8771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants