New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph: prometheus rules format changes #8774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the tools run? Are they on the developer enlistment when creating these rules, or in some CI? As long as it's enforced somewhere that would be good for consistency
cluster/examples/kubernetes/ceph/monitoring/prometheus-ceph-v14-rules.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c9ffcd5
to
c89b1fb
Compare
Due to the latest jsonnet and jsonnetfmt, v0.17.0, we have the `description` and `message` lines format changed. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
c89b1fb
to
55faa31
Compare
@aruniiird does this need to be backported? |
Yes @leseb ... |
ceph: prometheus rules format changes (backport #8774)
Due to the latest jsonnet and jsonnetfmt, v0.17.0, we have the
description
andmessage
lines format changed.Signed-off-by: Arun Kumar Mohan amohan@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.