Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring: add namespace to ceph node down query #8793

Merged
merged 1 commit into from Sep 27, 2021
Merged

monitoring: add namespace to ceph node down query #8793

merged 1 commit into from Sep 27, 2021

Conversation

aruniiird
Copy link
Contributor

This PR is on top of PR #8774

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb leseb changed the title Add namespace to ceph node down query monitoring: add namespace to ceph node down query Sep 23, 2021
@leseb leseb added this to In progress in v1.7 via automation Sep 23, 2021
@aruniiird aruniiird force-pushed the add-namespace-to-ceph-node-down-query branch from 660534c to 502d4ee Compare September 23, 2021 19:49
@BlaineEXE
Copy link
Member

BlaineEXE commented Sep 24, 2021 •
edited

@Mergifyio rebase

(to try to get CI to pass)

BlaineEXE
BlaineEXE approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the very clear messages for users about how to resolve the issue. 👍

@mergify
Copy link

mergify bot commented Sep 24, 2021

Command rebase: success

Branch has been successfully rebased

@leseb leseb force-pushed the add-namespace-to-ceph-node-down-query branch from 502d4ee to 1fde2f0 Compare September 24, 2021 17:40
@leseb
Copy link
Member

leseb commented Sep 27, 2021

@Mergifyio rebase

@aruniiird
ceph: adding 'namespace' into the result of 'ceph_node_down' query
11ff00e 
This will add 'namespace' field into the result of 'ceph_node_down'
query.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@mergify
Copy link

mergify bot commented Sep 27, 2021

Command rebase: success

Branch has been successfully rebased

@leseb leseb force-pushed the add-namespace-to-ceph-node-down-query branch from 1fde2f0 to 11ff00e Compare September 27, 2021 08:37
@leseb leseb merged commit ccdc5e9 into rook:master Sep 27, 2021
v1.7 automation moved this from In progress to Done Sep 27, 2021
@mergify mergify bot mentioned this pull request Sep 27, 2021
Merged
leseb added a commit that referenced this pull request Sep 27, 2021
@leseb
Merge pull request #8835 from rook/mergify/bp/release-1.7/pr-8793
b186a7f 
monitoring: add namespace to ceph node down query (backport #8793)
@aruniiird aruniiird mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@BlaineEXE BlaineEXE BlaineEXE approved these changes

Assignees
No one assigned
Labels
monitoring
Projects
No open projects
v1.7
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aruniiird @BlaineEXE @leseb