Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fix external script when passing monitoring list #8807

Merged
merged 1 commit into from Sep 28, 2021
Merged

ceph: fix external script when passing monitoring list #8807

merged 1 commit into from Sep 28, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 23, 2021

Description of your changes:

If we call the script with --monitoring-endpoint
10.1.8.29,10.1.8.36,10.1.8.25, we need to parse each comma-separated
address and not the entire block.
Now each address is tested properly.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Sep 23, 2021
aruniiird
aruniiird approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@aruniiird aruniiird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good...

@aruniiird aruniiird self-requested a review September 28, 2021 13:19
@leseb
ceph: fix external script when passing monitoring list
f47b870 
If we call the script with --monitoring-endpoint
10.1.8.29,10.1.8.36,10.1.8.25, we need to parse each comma-separated
address and not the entire block.
Now each address is tested properly.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb merged commit 62d66b0 into rook:master Sep 28, 2021
@leseb leseb deleted the fix-bz-2007130 branch September 28, 2021 14:01
@mergify mergify bot mentioned this pull request Sep 28, 2021
Merged
leseb added a commit that referenced this pull request Sep 29, 2021
@leseb
Merge pull request #8857 from rook/mergify/bp/release-1.7/pr-8807
ca7be19 
ceph: fix external script when passing monitoring list (backport #8807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniiird aruniiird Awaiting requested review from aruniiird

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leseb @aruniiird @travisn