Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: update csi sidecar version references to the latest #8820

Merged
merged 1 commit into from Sep 24, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Sep 24, 2021

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Sep 24, 2021
@humblec humblec changed the title ceph: update csi sidecar versions references to the latest ceph: update csi sidecar version references to the latest Sep 24, 2021
@humblec
Copy link
Contributor Author

humblec commented Sep 24, 2021

@travisn ptal.. thanks!

@humblec
Copy link
Contributor Author

humblec commented Sep 24, 2021

Run timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
+ timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
Defaulted container "fs-mirror" out of: fs-mirror, chown-container-data-dir (init)
waiting for connection to peer

@humblec
Copy link
Contributor Author

humblec commented Sep 24, 2021

cc @leseb

@leseb
Copy link
Member

leseb commented Sep 24, 2021

Run timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
+ timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
Defaulted container "fs-mirror" out of: fs-mirror, chown-container-data-dir (init)
waiting for connection to peer

Unrelated. Waiting for @travisn to approve.

@leseb
Copy link
Member

leseb commented Sep 24, 2021

Run timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
+ timeout 45 sh -c 'until [ "$(kubectl -n rook-ceph exec -t deploy/rook-ceph-fs-mirror -- ls -1 /var/run/ceph/|grep -c asok)" -lt 3 ]; do echo "waiting for connection to peer" && sleep 1; done'
Defaulted container "fs-mirror" out of: fs-mirror, chown-container-data-dir (init)
waiting for connection to peer

Unrelated. Waiting for @travisn to approve.

Ah sorry I thought it was #8803, nevermind.

Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need 3 commits for this. One will suffice. Thanks

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Sep 24, 2021

You don't need 3 commits for this. One will suffice. Thanks

@leseb consolidated to one commit. ptal .. thanks.

@humblec humblec requested a review from leseb September 24, 2021 12:56
@BlaineEXE BlaineEXE merged commit 01bc8ab into rook:master Sep 24, 2021
travisn added a commit that referenced this pull request Sep 24, 2021
ceph: update csi sidecar version references to the latest (backport #8820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants