ceph: add missing rights rook-ceph-purge-osd account #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
reviewed
Sep 27, 2021
| @@ -82,7 +82,7 @@ rules: | |||
| verbs: ["get", "list", "delete" ] | |||
| - apiGroups: [""] | |||
| resources: ["persistentvolumeclaims"] | |||
| verbs: ["delete"] | |||
| verbs: ["get", "update", "delete"] | |||
There was a problem hiding this comment.
update might also be needed because we remove the ceph.rook.io/DeviceSetPVCId label from the pvc if its decided to be preserved.
The purge osd job need to read and update persistentvolumeclaims While the job doesn't failed with osd and deployments well deleted The associated pvc is not deleted by the job as it failed to read it Signed-off-by: n.fraison <n.fraison@criteo.com>
ashangit
force-pushed
the
purge_missing_rights
branch
from
2b94cee
to
5150018
Compare
sp98
approved these changes
Sep 28, 2021
satoru-takeuchi
approved these changes
Sep 28, 2021
satoru-takeuchi
added a commit
that referenced
this pull request
Sep 28, 2021
ceph: add missing rights rook-ceph-purge-osd account (backport #8833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
The purge osd job need to read and update persistentvolumeclaims
While the job doesn't failed with osd and deployments well deleted, the associated pvc is not deleted by the job as it failed to read it
Checklist:
make codegen) has been run to update object specifications, if necessary.