Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the example of local PVC based cluster #8846

Conversation

satoru-takeuchi
Copy link
Member

Description of your changes:

PV for mon must be a filesystem volume.

Which issue is resolved by this Pull Request:
Resolves #8818

Checklist:

  • [o] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [o] Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • [o] Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • [o] Reviewed the developer guide on Submitting a Pull Request
  • [o] Documentation has been updated, if necessary.
  • [o] Unit tests have been added, if necessary.
  • [o] Integration tests have been added, if necessary.
  • [o] Pending release notes updated with breaking and/or notable changes, if necessary.
  • [o] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • [o] Code generation (make codegen) has been run to update object specifications, if necessary.

PV for mon must be a filesystem volume.

Closes: rook#8818

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
@satoru-takeuchi satoru-takeuchi merged commit 15fd707 into rook:master Sep 28, 2021
@mergify
Copy link

mergify bot commented Sep 28, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @satoru-takeuchi please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@satoru-takeuchi satoru-takeuchi deleted the docs-fix-the-example-of-local-pvc-based-cluster branch September 28, 2021 05:14
satoru-takeuchi added a commit that referenced this pull request Sep 28, 2021
docs: fix the example of local PVC based cluster (backport #8846)
@inouekazu
Copy link

Question about Rook/Ceph conventions: I've confirmed that there is no need to separate StorageClasses [1], but is it customary not to separate them, e.g. local-storage-mon, local-storage-osd?

[1] https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/plugins/volumebinding/binder.go#L829
[1] https://alibaba-cloud.medium.com/kubernetes-persistent-storage-process-97372f86089d (FindBestMatchPVForClaim:)

@satoru-takeuchi
Copy link
Member Author

@inouekazu No, there is no such convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-on-local-pvc.yaml: rook-ceph-mon(canary) remains "pending"
3 participants