Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: do not fail on keys deletion #8868

Merged
merged 1 commit into from Sep 29, 2021
Merged

ceph: do not fail on keys deletion #8868

merged 1 commit into from Sep 29, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 29, 2021

Prior, we were returning a nil map and thus the assignment for forced
deletion was not working since we were trying to assign on a nil map.

Signed-off-by: Sébastien Han seb@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: do not fail on keys deletion
2e73baf 
Prior, we were returning a nil map and thus the assignment for forced
deletion was not working since we were trying to assign on a nil map.

Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Sep 29, 2021
@leseb leseb merged commit 85612b1 into rook:master Sep 29, 2021
@leseb leseb deleted the fix-crash-kms-deletion branch September 29, 2021 14:44
@mergify mergify bot mentioned this pull request Sep 29, 2021
Merged
mergify bot added a commit that referenced this pull request Sep 29, 2021
@mergify
Merge pull request #8873 from rook/mergify/bp/release-1.7/pr-8868
e7e4801 
ceph: do not fail on keys deletion (backport #8868)
@mergify mergify bot mentioned this pull request Oct 1, 2021
Merged
leseb added a commit that referenced this pull request Oct 6, 2021
@leseb
Merge pull request #8903 from rook/mergify/bp/release-1.6/pr-8868
3380729 
ceph: do not fail on keys deletion (backport #8868)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn