Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: change CephAbsentMgr to use 'up' query #8882

Merged
merged 1 commit into from Sep 30, 2021
Merged

ceph: change CephAbsentMgr to use 'up' query #8882

merged 1 commit into from Sep 30, 2021

Conversation

aruniiird
Copy link
Contributor

Instead of using 'absent' query, we are trying to use 'up' which should
provide us with the needed 'namespace' field in the resultant metrics

Signed-off-by: aruniiird amohan@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@aruniiird
ceph: change CephAbsentMgr to use 'up' query
854eb01 
Instead of using 'absent' query, we are trying to use 'up' which should
provide us with the needed 'namespace' field in the resultant metrics

Signed-off-by: aruniiird <amohan@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Sep 29, 2021
@aruniiird
Copy link
Contributor Author

@anmolsachan , @leseb please take a look.

@leseb leseb merged commit 1f49b6f into rook:master Sep 30, 2021
@mergify mergify bot mentioned this pull request Sep 30, 2021
Merged
mergify bot added a commit that referenced this pull request Oct 1, 2021
@mergify
Merge pull request #8888 from rook/mergify/bp/release-1.7/pr-8882
1146370 
ceph: change CephAbsentMgr to use 'up' query (backport #8882)
@aruniiird aruniiird mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aruniiird @leseb