ceph: fixing ClientID of log-collector for RGW instance #8889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-gr
force-pushed
the
logrotate-object
branch
from
9909c43
to
9546b33
Compare
parth-gr
changed the title
|
rook/pkg/operator/ceph/controller/spec.go Line 80 in 1f49b6f |
leseb
requested changes
Sep 30, 2021
parth-gr
force-pushed
the
logrotate-object
branch
from
9546b33
to
8d9bc5e
Compare
leseb
requested changes
Sep 30, 2021
| ResourceName: resourceName, | ||
| } | ||
| daemon := getDaemonName(rgwConfig) | ||
| assert.Equal(t, "ceph-client.rgw.default", daemon) |
There was a problem hiding this comment.
The daemon log also has the daemon ID which is missing in the example, e,g: ceph-client.rgw.my.store.a.log. Let's make this example more realistic.
There was a problem hiding this comment.
I would also suggest that we should have 2 test cases for the unit test to make sure that it works as expected for different inputs.
parth-gr
force-pushed
the
logrotate-object
branch
from
8d9bc5e
to
aa07551
Compare
subhamkrai
approved these changes
Oct 4, 2021
leseb
requested changes
Oct 6, 2021
parth-gr
force-pushed
the
logrotate-object
branch
from
aa07551
to
aa9c6b8
Compare
The Client_ID generated by operator was different from the log rotate file created The Clinet_ID= rgwceph.client.rook.ceph.rgw.my.store.a and log file name= ceph-client.rgw.my.store.a.log So changed the CLient_ID to ceph-client.rgw.my.store.a for correct working and this follow the patterns how other modules Client_ID is generated Closes: rook#8692 Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
logrotate-object
branch
from
aa9c6b8
to
fc7905a
Compare
leseb
approved these changes
Oct 7, 2021
mergify bot
added a commit
that referenced
this pull request
Oct 11, 2021
ceph: fixing ClientID of log-collector for RGW instance (backport #8889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves # #8692
Checklist:
make codegen) has been run to update object specifications, if necessary.