Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: close stdoutPipe for the discovery daemon #8917

Merged
merged 1 commit into from Oct 5, 2021

Conversation

subhamkrai
Copy link
Contributor

Closing stdoutPipe that could possibly
leaks memory due to unclosed resources.

Closes: #8914
Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #8914

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add to the commit and PR title that this is for the discovery daemon? Then it's more clear for release notes

@subhamkrai subhamkrai changed the title core: close stdoutPipe core: close stdoutPipe for the discovery daemon Oct 5, 2021
@subhamkrai
Copy link
Contributor Author

Could you just add to the commit and PR title that this is for the discovery daemon? Then it's more clear for release notes

done.

@travisn
Copy link
Member

travisn commented Oct 5, 2021

@Mergifyio rebase

Closing stdoutPipe for the discovery daemon that
could possibly leaks memory due to unclosed resources.

Closes: rook#8914
Signed-off-by: subhamkrai <srai@redhat.com>
@mergify
Copy link

mergify bot commented Oct 5, 2021

Command rebase: success

Branch has been successfully rebased

@travisn travisn merged commit 00cef45 into rook:master Oct 5, 2021
mergify bot added a commit that referenced this pull request Oct 5, 2021
core:  close stdoutPipe for the discovery daemon (backport #8917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report a coding issue that possibly leaks memory due to unclosed resources
2 participants