Handle empty ceph_version in ceph_mon_metadata to avoid raising misleading alert #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GowthamShanmugam
force-pushed
the
1970354
branch
2 times, most recently
from
1c9480a
to
3444303
Compare
leseb
requested changes
Oct 11, 2021
| @@ -32,4 +32,3 @@ spec: | |||
| for: 5s | |||
| labels: | |||
| severity: critical | |||
|
|
|||
GowthamShanmugam
force-pushed
the
1970354
branch
2 times, most recently
from
6be7a75
to
d2b0227
Compare
leseb
approved these changes
Oct 12, 2021
|
@GowthamShanmugam see the commit lint error. |
GowthamShanmugam
force-pushed
the
1970354
branch
4 times, most recently
from
35e51b6
to
04f9655
Compare
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
1970354
branch
from
04f9655
to
4b76eb8
Compare
leseb
added a commit
that referenced
this pull request
Oct 13, 2021
Handle empty ceph_version in ceph_mon_metadata to avoid raising misleading alert (backport #8947)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the ceph version, we can't clearly report that the version is different, or that the version is the same.
QE already raised a BZ at the ceph side to fix this. We are adding this not empty check to avoid misreport from other cases also.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1970354
Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.