Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: add affinity to csi version check job #8965

Merged
merged 1 commit into from Oct 13, 2021

Conversation

Rakshith-R
Copy link
Member

Fixes: #8323

Signed-off-by: Rakshith R rar@redhat.com

[rakshith@fedora rook]$ k get pod rook-ceph-csi-detect-version-4qdkw -oyaml 
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2021-10-13T09:04:38Z"
  generateName: rook-ceph-csi-detect-version-
  labels:
    app: rook-ceph-csi-detect-version
    controller-uid: c0d82ed3-2b57-48ad-b0ef-af91a7595151
    job-name: rook-ceph-csi-detect-version
    rook-version: v1.7.0-alpha.0.447.g7c863d53a
  name: rook-ceph-csi-detect-version-4qdkw
  namespace: rook-ceph
  ownerReferences:
  - apiVersion: batch/v1
    blockOwnerDeletion: true
    controller: true
    kind: Job
    name: rook-ceph-csi-detect-version
spec:
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchExpressions:
          - key: kubernetes.io/os
            operator: In
            values:
            - ' linux'
     

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@Rakshith-R Rakshith-R requested a review from leseb October 13, 2021 09:12
@mergify mergify bot added the ceph main ceph tag label Oct 13, 2021
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a better commit message and we should be good to go.

This commit makes sure csi provisioner node-affinity is applied
to the csi version check job as well, similar to the how
the existing csi provisioner toleration is applied to the job.

Fixes: rook#8323

Signed-off-by: Rakshith R <rar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-Selectors value not getting populated with setting CSI_PROVISIONER_NODE_AFFINITY
4 participants