Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: remove default value for pool compression #8966

Merged
merged 1 commit into from Oct 13, 2021
Merged

ceph: remove default value for pool compression #8966

merged 1 commit into from Oct 13, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Oct 13, 2021

Description of your changes:

Using a default value for CompressionMode to none effectively overrides
any values for Parameters. It is deprecated but still takes precedence.
Which means that in its previous form, Parameters was always ignored
since CompressionMode was always set to none when empty.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Oct 13, 2021
@leseb
ceph: remove default value for pool compression
28cc6f5 
Using a default value for CompressionMode to none effectively overrides
any values for Parameters. It is deprecated but still takes precedence.
Which means that in its previous form, Parameters was always ignored
since CompressionMode was always set to none when empty.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from travisn October 13, 2021 15:18
@leseb leseb merged commit 5e3ecaa into rook:master Oct 13, 2021
@leseb leseb deleted the rm-compression-mode branch October 13, 2021 16:13
@mergify mergify bot mentioned this pull request Oct 13, 2021
Merged
mergify bot added a commit that referenced this pull request Oct 13, 2021
@mergify
Merge pull request #8972 from rook/mergify/bp/release-1.7/pr-8966
3088a6d 
ceph: remove default value for pool compression (backport #8966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn