ceph: Enable mon failover for the arbiter in stretch mode #8984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp98
requested changes
Oct 18, 2021
leseb
reviewed
Oct 18, 2021
| c.ClusterInfo = clienttest.CreateTestClusterInfo(1) | ||
| monName := "arb" | ||
|
|
||
| // don't skip failover for non-stretch |
There was a problem hiding this comment.
Let's use t.Run() like in a few other places to properly name the tests instead of the comments.
| } | ||
| return true | ||
| } | ||
|
|
||
| func (c *Cluster) shouldSkipFailover(name string) bool { |
There was a problem hiding this comment.
Can we return errors instead here so then the caller can print it. With that, we know why we are skipping the failover.
travisn
force-pushed
the
support-arbiter-failover
branch
from
12d69ba
to
cb34e2c
Compare
sp98
approved these changes
Oct 18, 2021
leseb
approved these changes
Oct 18, 2021
| } | ||
|
|
||
| // Ceph does not support updating the arbiter mon in older versions | ||
| return errors.Errorf("refusing to failover arbiter mon %q on a stretched cluster until upgrading to ceph version v16.2.7", name) |
There was a problem hiding this comment.
use arbiterFailoverSupportedCephVersion.String()?
Prior to ceph v16.2.7 the failover of the arbiter mon was not supported. Now the new tiebreaker mon can be set during the failover event and provide more dynamic stability to the mon quorum if another node is available in the arbiter zone. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
support-arbiter-failover
branch
from
cb34e2c
to
12689bd
Compare
travisn
added a commit
that referenced
this pull request
Oct 18, 2021
ceph: Enable mon failover for the arbiter in stretch mode (backport #8984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Prior to ceph v16.2.7 the failover of the arbiter mon was not supported. Now the new tiebreaker mon can be set during the failover event and provide more dynamic stability to the mon quorum as long as another node is available in the arbiter
zone.
Checklist:
make codegen) has been run to update object specifications, if necessary.