ceph: update endpoint with IP for external RGW server

[thotz]

Description of your changes:
For external RGW server use the IP mentioned in Gateway for admin Ops
operattions.

Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com

Which issue is resolved by this Pull Request:
Resolves #8916

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
• Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
• Reviewed the developer guide on Submitting a Pull Request
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.
• Pending release notes updated with breaking and/or notable changes, if necessary.
• Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
• Code generation (make codegen) has been run to update object specifications, if necessary.

[subhamkrai]

@thotz can you explain more about the changes like what is the problem... just for my understanding? Thanks

[thotz]

@thotz can you explain more about the changes like what is the problem... just for my understanding? Thanks

Basically fix based on my code reading, so I might be wrong here as well.

The current code always generate endpoint for the adminOps from appName, namespace and service name. But for external cluster we already have the external IP for the RGW in the objectstoreSpec. I guess the failure of the health checker was due to that.

[leseb]

I'm not sure why this is needed, the service should be present and pointing to the ExternalRgwEndpoints already. I haven't fully read the issue but I don't see how this code is fixing anything (yet?). Thanks

[leseb]

I'm not sure why this is needed, the service should be present and pointing to the ExternalRgwEndpoints already. I haven't fully read the issue but I don't see how this code is fixing anything (yet?). Thanks

Actually, if the service is not there, it might be that it's created later?

[thotz]

I'm not sure why this is needed, the service should be present and pointing to the ExternalRgwEndpoints already. I haven't fully read the issue but I don't see how this code is fixing anything (yet?). Thanks

Actually, if the service is not there, it might be that it's created later?

That's possible I guess

[leseb]

This looks more like the right fix for this issue. Can we validate this via the controller_test.go?

[thotz]

This looks more like the right fix for this issue. Can we validate this via the controller_test.go?

@leseb : The endpoint is saved in objcontext, if I understand correctly it is local to reconcileCreateObjectStore and we cannot check that value from units written for Reconcile in controller_test.go

[leseb]

This looks more like the right fix for this issue. Can we validate this via the controller_test.go?

@leseb : The endpoint is saved in objcontext, if I understand correctly it is local to reconcileCreateObjectStore and we cannot check that value from units written for Reconcile in controller_test.go

Sounds good and I just realized there are no unit tests for external mode either... #9025