nfs: add pool setting CR option #9040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Oct 26, 2021
leseb
force-pushed
the
fix-9034
branch
4 times, most recently
from
a0c78d4
to
d43cfdd
Compare
travisn
reviewed
Oct 27, 2021
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
travisn
requested changes
Oct 28, 2021
Ths NFS spec now supports the CephBlockPool spec which means that it can take advantage of all the known settings like compression, size, failure domain etc. Closes: rook#9034 Signed-off-by: Sébastien Han <seb@redhat.com>
travisn
approved these changes
Oct 29, 2021
mergify bot
added a commit
that referenced
this pull request
Nov 3, 2021
nfs: add pool setting CR option (backport #9040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Ths NFS spec now supports the CephBlockPool spec which means that it can
take advantage of all the known settings like compression, size, failure
domain etc.
Closes: #9034
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #9034
Checklist:
make codegen) has been run to update object specifications, if necessary.