Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: ability to set label to crash collector #9044

Merged
merged 1 commit into from Oct 27, 2021
Merged

ceph: ability to set label to crash collector #9044

merged 1 commit into from Oct 27, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Oct 27, 2021

Description of your changes:

We can now set labels to the crash collector deployment by editing the
CephCluster CR with:

spec:
  labels:
    crashcollector:

Closes: #9039
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #9039

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: ability to set label to crash collector
4f2c685 
We can now set labels to the crash collector deployment by editing the
CephCluster CR with:

```yaml
spec:
  labels:
    crashcollector:
```

Closes: rook#9039
Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Oct 27, 2021
@leseb leseb requested a review from travisn October 27, 2021 11:49
travisn
travisn approved these changes Oct 27, 2021
View reviewed changes
Documentation/ceph-cluster-crd.md Show resolved Hide resolved
@leseb leseb merged commit f55479b into rook:master Oct 27, 2021
@leseb leseb deleted the fix-9039 branch October 27, 2021 16:40
@mergify mergify bot mentioned this pull request Oct 27, 2021
Merged
mergify bot added a commit that referenced this pull request Oct 28, 2021
@mergify
Merge pull request #9050 from rook/mergify/bp/release-1.7/pr-9044
c90ccbe 
ceph: ability to set label to crash collector (backport #9044)
@satoru-takeuchi satoru-takeuchi mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set custom labels to Ceph crashcollector pods
2 participants
@leseb @travisn