helm: Add appVersion property to the charts #9051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
reviewed
Oct 27, 2021
cluster/charts/library/Chart.yaml
Outdated
| @@ -2,6 +2,7 @@ apiVersion: v2 | |||
| name: library | |||
| description: A simple library chart to share content between Rook's charts | |||
| version: 0.0.1 | |||
| appVersion: 0.0.1 | |||
There was a problem hiding this comment.
Do we need this for the library? It's not a top-level chart that contains any app but a library of reusable teplates, so I think maybe this is best left out?
There was a problem hiding this comment.
yeah, not necessary for the library, was just mirroring the version property. I'll remove it.
| icon: https://rook.io/images/rook-logo.svg | ||
| sources: | ||
| - https://github.com/rook/rook | ||
| dependencies: | ||
| - name: library | ||
| version: "0.0.1" | ||
| appVersion: "0.0.1" |
There was a problem hiding this comment.
I don't think we need to specify the app version for the dependency. It isn't present for the rook-ceph chart I see below.
The appVersion should be set to the version of the application. Since the helm charts are built by Rook in the same release version as Rook itself, the version and appVersion values will be the same. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
helm-app-version
branch
from
d734abd
to
bffe99c
Compare
BlaineEXE
approved these changes
Oct 28, 2021
leseb
added a commit
that referenced
this pull request
Oct 29, 2021
helm: Add appVersion property to the charts (backport #9051)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The appVersion should be set to the version of the application. Since the helm charts are built by Rook in the same release version as Rook itself, the version and appVersion values will be the same.
Which issue is resolved by this Pull Request:
Resolves #3589
Checklist:
make codegen) has been run to update object specifications, if necessary.