New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph: support ephemeral volumes with Ceph CSI RBD and CephFS driver #9055
Conversation
877088b
to
d055e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humblec care to send a PR with the same details to cephcsi also?
# kubectl delete pod csi-cephfs-demo-ephemeral-pod | ||
pod "csi-cephfs-demo-ephemeral-pod" deleted | ||
|
||
# kubectl get pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.. just thought of mentioning it as a confirmation that, pod got deleted successfully and not stuck.
I was done with ceph csi first, then the RBAC changes looked to be required, so droppped the PR first here. any way I will file the Ceph CSI too |
b5143b4
to
4829fa7
Compare
156bf93
to
713e9e8
Compare
e8a4e6a
to
b0faa4b
Compare
@travisn I have trimmed the content and added to csi-drivers.md, ptal.. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few more suggestions, thanks!
This commit make required changes for ceph csi drivers to work with ephemeral volume support. With ephemeral volume support a user can specify ephemeral volumes in its pod spec and tie the lifecycle of the PVC with the POD. An example POD spec looks like this: ``` kind: Pod apiVersion: v1 metadata: name: csi-rbd-demo-ephemeral-pod spec: containers: - name: web-server image: docker.io/library/nginx:latest volumeMounts: - mountPath: "/myspace" name: mypvc volumes: - name: mypvc ephemeral: volumeClaimTemplate: spec: accessModes: ["ReadWriteOnce"] storageClassName: "rook-ceph-block" resources: requests: storage: 1Gi ``` Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Thanks @travisn .. Documentation patches are the difficult one to get in shape :) , ptal at latest version. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ceph: support ephemeral volumes with Ceph CSI RBD and CephFS driver (backport #9055)
This commit make required changes for ceph csi drivers to work with
ephemeral volume support. With ephemeral volume support a user can
specify ephemeral volumes in its pod spec and tie the lifecycle
of the PVC with the POD.
An example POD spec looks like this:
Signed-off-by: Humble Chirammal hchiramm@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.