Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: do not set the balancer mode on pacific #9063

Merged
merged 1 commit into from Oct 29, 2021
Merged

mgr: do not set the balancer mode on pacific #9063

merged 1 commit into from Oct 29, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Oct 29, 2021

Description of your changes:

On Pacific, Ceph's default is "upmap", so we should let it be like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: #9062
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #9062

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb leseb requested a review from travisn October 29, 2021 12:43
travisn
travisn requested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
@leseb
mgr: do not set the balancer mode on pacific
bccc84e 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from travisn October 29, 2021 13:43
@leseb leseb merged commit 2db8288 into rook:master Oct 29, 2021
@leseb leseb deleted the fix-9062 branch October 29, 2021 14:52
@mergify mergify bot mentioned this pull request Oct 29, 2021
Merged
mergify bot added a commit that referenced this pull request Oct 29, 2021
@mergify
Merge pull request #9072 from rook/mergify/bp/release-1.7/pr-9063
c4adacc 
mgr: do not set the balancer mode on pacific (backport #9063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rook not support selecting mode of balancer when balancer was enabled
2 participants
@leseb @travisn