ceph: fix 'CephMonQuorumLost' alert #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @leseb |
Only the 'Running' mons with result value of '1' should be counted. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
leseb
requested changes
Nov 2, 2021
aruniiird
force-pushed
the
fix-CephMonQuorumLost-alert-query
branch
from
f5df591
to
af44e5c
Compare
leseb
approved these changes
Nov 2, 2021
travisn
reviewed
Nov 2, 2021
| @@ -90,7 +90,7 @@ spec: | |||
| severity_level: critical | |||
| storage_type: ceph | |||
| expr: | | |||
| count(kube_pod_status_phase{pod=~"rook-ceph-mon-.*", phase=~"Running|running"}) by (namespace) < 2 | |||
| count(kube_pod_status_phase{pod=~"rook-ceph-mon-.*", phase=~"Running|running"} == 1) by (namespace) < 2 | |||
There was a problem hiding this comment.
Doesn't the < 2 already cover the == 1 case?
There was a problem hiding this comment.
In the above example, we can see that if pod is in running phase value is 1 (at the right end). But if the pod is not running, the value is ZERO. So we have to collect / count pods which are in valid running state, that means the value is ONE.
mergify bot
added a commit
that referenced
this pull request
Nov 2, 2021
ceph: fix 'CephMonQuorumLost' alert (backport #9068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the 'Running' mons with result value of '1' should be counted.
Signed-off-by: Arun Kumar Mohan amohan@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.