rgw: change the way to livenessProbe and introduce readinessProbe #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgw doesn't respond `livenessProbe` if the number of connection reaches its limit (by default, 1000). Then rgw is out of service but still live. Hense the current `livenessProbe` logic is suitiable for `readinessProbe`. `tcpSocket` is enough for `livenessProbe`. Remove rgw-multisite-test related code because this test doesn't exist in release-1.7 branch. Closes: rook#8407 Signed-off-by: Yuzuki Mimura <yuzuki725.m@gmail.com> Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com> (cherry picked from commit 536b59e)
satoru-takeuchi
added
backport
satoru-takeuchi
requested review from
travisn
and removed request for
travisn
travisn
approved these changes
Nov 1, 2021
satoru-takeuchi
deleted the
rgw-change-the-way-to-livenessprobe-and-introduce-readiness-probe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
rgw doesn't respond
livenessProbeif the number of connection reaches its limit (by default, 1000). Then rgw is out of service but still live. Hense the currentlivenessProbelogic is suitiable forreadinessProbe.tcpSocketis enough forlivenessProbe.Remove rgw-multisite-test related code because this test doesn't exist in release-1.7 branch.
Checklist:
make codegen) has been run to update object specifications, if necessary.