Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd-mirror: use a sorted list for peer token content #9091

Merged
merged 1 commit into from Nov 3, 2021
Merged

rbd-mirror: use a sorted list for peer token content #9091

merged 1 commit into from Nov 3, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Nov 3, 2021

Description of your changes:

The monitor list was not sorted, so each time we were reconciling, the
peer secret token will see its content updated with randomized
monitors. This would enter our predicate and trigger a reconcile.
Potentially an endless one, if the randomized list is already different.

Closes: #9076
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #9076

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb leseb requested a review from travisn November 3, 2021 16:41
@leseb
rbd-mirror: use a sorted list for peer token content
8cb6cdc 
The monitor list was not sorted, so each time we were reconciling, the
peer secret token will see its content updated with randomized
monitors. This would enter our predicate and trigger a reconcile.
Potentially an endless one, if the randomized list is already different.

Closes: rook#9076
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb changed the title mirror: use a sorted list for peer token content rbd-mirror: use a sorted list for peer token content Nov 3, 2021
@leseb leseb merged commit 01bb0c1 into rook:master Nov 3, 2021
@leseb leseb deleted the fix-9076 branch November 3, 2021 17:22
@mergify mergify bot mentioned this pull request Nov 3, 2021
Merged
leseb added a commit that referenced this pull request Nov 4, 2021
@leseb
Merge pull request #9093 from rook/mergify/bp/release-1.7/pr-9091
648bb48 
rbd-mirror: use a sorted list for peer token content (backport #9091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator run in a loop until CephBlockPool is created
2 participants
@leseb @travisn