Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: Allow more data chunks in an ec pool #9107

Merged
merged 1 commit into from Nov 5, 2021
Merged

pool: Allow more data chunks in an ec pool #9107

merged 1 commit into from Nov 5, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Nov 4, 2021

Description of your changes:
The schema has a limit of nine data and nine coding chunks in an EC pool. More data chunks may be desired, even if not typically recommended due to the higher recovery cost. To allow for the higher chunks sizes if desired, we increase the limit.

Which issue is resolved by this Pull Request:
Resolves #9106

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn travisn requested a review from leseb November 4, 2021 19:17
@SSSCeph
Copy link

SSSCeph commented Nov 5, 2021

Awesome - thanks a ton for doing this!

leseb
leseb requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the offline discussion let's keep the chunks unbounded.

@travisn
pool: allow more data chunks in an ec pool
53b6c71 
The schema has a limit of 9 data and 9 coding chunks in an EC pool.
While not typically recommended, more data chunks may be desired.
Ceph does not have a limit, so we match the behavior and also
allow any number of desired chunks to be specified.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn merged commit be48cc8 into rook:master Nov 5, 2021
@travisn travisn deleted the ec-maximum branch November 5, 2021 16:13
@mergify mergify bot mentioned this pull request Nov 5, 2021
Merged
mergify bot added a commit that referenced this pull request Nov 5, 2021
@mergify
Merge pull request #9114 from rook/mergify/bp/release-1.7/pr-9107
dba9ecb 
pool: Allow more data chunks in an ec pool (backport #9107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump up the maximum number of allowed data chunks in EC.
3 participants
@travisn @SSSCeph @leseb