Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fail if config dir creation fails #9122

Merged
merged 1 commit into from Nov 8, 2021
Merged

core: fail if config dir creation fails #9122

merged 1 commit into from Nov 8, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Nov 8, 2021

Description of your changes:

If the operator fails to create the operator's configuration directory
then we should fail the Operator.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
core: fail if config dir creation fails
10a114a 
If the operator fails to create the operator's configuration directory
then we should fail the Operator.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb merged commit dd351a9 into rook:master Nov 8, 2021
@leseb leseb deleted the error-on-failure branch November 8, 2021 08:51
@mergify mergify bot mentioned this pull request Nov 8, 2021
Merged
mergify bot added a commit that referenced this pull request Nov 8, 2021
@mergify
Merge pull request #9124 from rook/mergify/bp/release-1.7/pr-9122
ed1e39e 
core: fail if config dir creation fails (backport #9122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoru-takeuchi satoru-takeuchi satoru-takeuchi approved these changes

@subhamkrai subhamkrai subhamkrai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leseb @satoru-takeuchi @subhamkrai