Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Enable cephfs volume expansion by default #9128

Merged
merged 1 commit into from Nov 10, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Nov 8, 2021

Description of your changes:
The cluster helm chart missed adding the default setting for the volume expansion, so now we enable it by default.

Which issue is resolved by this Pull Request:
Resolves #9120

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Copy link
Member

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowVolumeExpansion: line in cephblocksystem also needs to be added to cephfilesystem.yaml

reclaimPolicy: {{ default "Delete" $blockpool.storageClass.reclaimPolicy }}
allowVolumeExpansion: {{ default "true" $blockpool.storageClass.allowVolumeExpansion }}
{{ end }}
{{ end }}

reclaimPolicy: {{ default "Delete" $filesystem.storageClass.reclaimPolicy }}
{{ end }}
{{ end }}

The cluster helm chart missed adding the default setting
for the volume expansion, so now we enable it by default.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Copy link
Member

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leseb leseb merged commit f07c944 into rook:master Nov 10, 2021
leseb added a commit that referenced this pull request Nov 10, 2021
helm: Enable cephfs volume expansion by default (backport #9128)
@travisn travisn deleted the cephfs-helm-expansion branch February 24, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling volumeexpansion of cephfs volumes via helm chart
4 participants