rgw: Raise errors when rgw daemon fails to be created #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation of the rgw deployment spec was swallowing errors if any issues are raised such as the tls cert not being found as expected in some configurations. We need to fail the reconcile so the error will be logged and the admin can identify the issue. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
leseb
approved these changes
Nov 10, 2021
| @@ -140,7 +140,7 @@ func (c *clusterConfig) startRGWPods(realmName, zoneGroupName, zoneName string) | |||
| // Create deployment | |||
| deployment, err := c.createDeployment(rgwConfig) | |||
| if err != nil { | |||
| return nil | |||
| return errors.Wrap(err, "failed to create rgw deployment") | |||
There was a problem hiding this comment.
😱 I can't believe we have this line.
alimaredia
approved these changes
Nov 10, 2021
This was referenced Nov 10, 2021
travisn
added a commit
that referenced
this pull request
Nov 10, 2021
rgw: Raise errors when rgw daemon fails to be created (backport #9137)
travisn
added a commit
that referenced
this pull request
Nov 10, 2021
rgw: Raise errors when rgw daemon fails to be created (backport #9137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The generation of the rgw deployment spec was swallowing errors if any issues are raised such as the tls cert not being found as expected in some configurations. We need to fail the reconcile so the error will be logged and the admin can identify the issue.
Which issue is resolved by this Pull Request:
Resolves #9134
Checklist:
make codegen) has been run to update object specifications, if necessary.