Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: fix search user in objectstore #9143

Merged
merged 2 commits into from Nov 24, 2021

Conversation

olivierbouffet
Copy link
Contributor

avoid failed reconcile when multiple multisite objectstore are configured

Signed-off-by: Olivier Bouffet olivier.bouffet@infomaniak.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #9100

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

avoid failed reconcile when multiple multisite objectstore are configured

Signed-off-by: Olivier Bouffet <olivier.bouffet@infomaniak.com>
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you change the commit prefix to something more specific like "object:" instead of "operator:"? thanks!

thotz
thotz previously requested changes Nov 12, 2021
pkg/operator/ceph/object/objectstore.go Outdated Show resolved Hide resolved
@olivierbouffet olivierbouffet changed the title operator: fix search user in objectstore object: fix search user in objectstore Nov 12, 2021
adding zonegroup and zone args to avoid failed reconcile

Signed-off-by: Olivier Bouffet <olivier.bouffet@infomaniak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants