Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Set correct ingress endpoint protocol #9181

Merged
merged 1 commit into from Nov 16, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Nov 15, 2021

Description of your changes:
In the helm chart, the ingress for the dashbard was always referring to the http-dashboard port on the dashboard service. If ssl is enabled the https-dashboard port must be specified, or else the dashboard will not be available through the ingress.

The default is also changed from http to https when the dashboard is installed through the cluster helm chart.

Which issue is resolved by this Pull Request:
Resolves #9152

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

In the helm chart, the ingress for the dashbard was always referring
to the http-dashboard port on the dashboard service. If ssl is enabled
the https-dashboard port must be specified, or else the dashboard
will not be available through the ingress.

The default is also changed from http to https when the dashboard
is installed through the cluster helm chart.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Comment on lines +101 to +102
# serve the dashboard using SSL
ssl: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option only feeds into the ingress object and not to any configs?

Copy link
Member

@BlaineEXE BlaineEXE Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nvm. This is the cluster chart that just gets passed through.

@travisn travisn merged commit 2d03a8e into rook:master Nov 16, 2021
@travisn travisn deleted the helm-ingress-https branch November 16, 2021 17:46
mergify bot added a commit that referenced this pull request Nov 16, 2021
helm: Set correct ingress endpoint protocol (backport #9181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rook-ceph-cluster chart, dashboard part: the ingress template points to the wrong service with SSL enabled
2 participants