New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add OMAP quick fix warning to upgrade guide #9187
docs: add OMAP quick fix warning to upgrade guide #9187
Conversation
Documentation/ceph-upgrade.md
Outdated
@@ -399,6 +399,10 @@ To migrate the setting, follow these steps: | |||
|
|||
## Ceph Version Upgrades | |||
|
|||
> **WARNING: There is a notice from Ceph for users upgrading to Ceph Pacific v16.2.6 or lower from | |||
> an earlier major version of Ceph. If you are upgrading to Ceph Pacific (v16), please upgrade to | |||
> v16.2.7 or higher if possible. See for more: https://github.com/rook/rook/issues/9185** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since v16.2.7 isn't available yet, how about if we also document here that they need to set the following before upgrading as you mentioned in the issue?
ceph config set global bluestore_fsck_quick_fix_on_mount false
ceph config set osd bluestore_fsck_quick_fix_on_mount false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they need to unless they have explicitly set them to true
on their own. Those commands will only change what I wrote for my example, but it won't help a user who set them using ceph config set osd.0 bluestore_fsck_quick_fix_on_mount true
.
They really should be seeing the issue, or we need to lay out the steps for them to determine if bluestore_fsck_quick_fix_on_mount
is set in their cluster and how to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your latest suggestion on the issue to ensure they are unset. What if we just recommend they run the unset commands before upgrading to pacific 16.2.0-16.2.6?
ac705c1
to
9d2d69b
Compare
``` | ||
{ | ||
# ... | ||
"config/global/bluestore_fsck_quick_fix_on_mount": "false", # <-- FALSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a simpler doc, how about we remove all the lines that are not the settings we are looking at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove most of them, but I think it's useful to see a few examples of non-relevant lines for comparison.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notably, I was a little confused by the osd_scrub_auto_repair
setting, so I think it's good to show as an irrelevant example in the output. And a couple examples of other config paths (the mgr
and mgr.a
in this case).
Ceph has recently reported that it may be unsafe to upgrade clusters from Nautilus/Octopus to Pacific v16.2.0 through v16.2.6. We are tracking this in Rook issue rook#9185. Add a warning to the upgrade doc about this. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
9d2d69b
to
1f87196
Compare
docs: add OMAP quick fix warning to upgrade guide (backport #9187)
docs: add OMAP quick fix warning to upgrade guide (backport #9187)
Ceph has recently reported that it may be unsafe to upgrade clusters
from Nautilus/Octopus to Pacific v16.2.0 through v16.2.6. We are
tracking this in Rook issue #9185.
Add a warning to the upgrade doc about this.
Signed-off-by: Blaine Gardner blaine.gardner@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.