docs: add details about HPA via KEDA #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Nov 18, 2021
| @@ -210,3 +210,30 @@ labels: | |||
| prometheus: k8s | |||
| [...] | |||
| ``` | |||
There was a problem hiding this comment.
It would be nice to have a table of contents at the top so new topics like this can be more easily discovered, but that is really a separate question from this PR.
travisn
reviewed
Nov 19, 2021
@travisn : May I skip validate-yaml for the keda.yaml file : diff --git a/tests/scripts/github-action-helper.sh b/tests/scripts/github-action-helper.sh
index 25b717af8..aea4f1325 100755
--- a/tests/scripts/github-action-helper.sh
+++ b/tests/scripts/github-action-helper.sh
@@ -132,8 +132,8 @@ function build_rook_all() {
function validate_yaml() {
cd cluster/examples/kubernetes/ceph
kubectl create -f crds.yaml -f common.yaml
- # skipping folders and some yamls that are only for openshift.
- manifests="$(find . -maxdepth 1 -type f -name '*.yaml' -and -not -name '*openshift*' -and -not -name 'scc*')"
+ # skipping folders and some yamls that are only for openshift, keda etc.
+ manifests="$(find . -maxdepth 1 -type f -name '*.yaml' -and -not -name '*openshift*' -and -not -name 'scc*' -and -not -name 'keda*')"
with_f_arg="$(echo "$manifests" | awk '{printf " -f %s",$1}')" # don't add newlineOtherwise I keda need to be installed by deafult |
travisn
requested changes
Nov 22, 2021
There was a problem hiding this comment.
@thotz Instead of skipping the yaml validation, how about following the pattern we use for the volume replication CRDs and install them as part of the validate_yaml() test?
By default HPA can use details about memory or CPU consumption for autoscaling, but also it can use custom metrics as well. There are alot provides supports HPA via customer and one of them is KEDA project. Here it is done with help of Prometheus Scaler Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
travisn
approved these changes
Nov 23, 2021
mergify bot
added a commit
that referenced
this pull request
Nov 24, 2021
docs: add details about HPA via KEDA (backport #9202)
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this pull request
Nov 24, 2021
docs: add details about HPA via KEDA (backport rook#9202) Signed-off-by: Tom Hellier <me@tomhellier.com>
BlaineEXE
reviewed
Apr 5, 2022
Comment on lines
+176
to
+180
| #create the KEDA CRDS | ||
| keda_version=2.4.0 | ||
| keda_url="https://github.com/kedacore/keda/releases/download/v${keda_version}/keda-${keda_version}.yaml" | ||
| kubectl apply -f "${keda_url}" | ||
|
|
There was a problem hiding this comment.
@thotz Why was this included (to install KEDA) but no integration test written to test KEDA integration with Rook RGWs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
By default HPA can use details about memory or CPU consumption for
autoscaling, but also it can use custom metrics as well. There are alot
provides supports HPA via customer and one of them is KEDA project. Here
it is done with help of Prometheus Scaler
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.