docs: add guide doc for flex migration #9222

subhamkrai · 2021-11-22T10:43:33Z

Description of your changes:
Adding guide doc for migrating rbd flexvolume to ceph-csi.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

subhamkrai · 2021-11-22T10:44:09Z

this is at top of #9221

Documentation/flexMigration/flex-to-csi-migration.md

Documentation/flex-to-csi-migration.md

travisn · 2021-11-24T15:25:22Z

Documentation/flex-to-csi-migration.md

+4. Create the CSI storage class to which you want to migrate
+5. Create migrator pod
+   1) `kubectl create -f <update this with file link in the tool repo>`
+6. Download the tool binary


I was thinking about an approach to build an image that includes the binary, and no need for this manual step to get it... In the 1.7 branch, we add an image to the build that is just like the rook ceph image, but it also includes the tool binary. Then the sample migrator.yaml would just pull that image. The image on dockerhub would appear as rook/flex-migration:v1.7.9, where the tag would be the latest 1.7.x release. Rooks existing release process should make this fairly simple to implement.

With that approach it makes sense to include the migrator.yaml in the rook repo as well.

The latest discussion is that we can just add the tool to the main rook image in the 1.7 releases. No need to create a new image.

do we still need migrator.yaml file in rook?

Documentation/flex-to-csi-migration.md

leseb · 2021-11-25T16:44:01Z

Documentation/flex-to-csi-migration.md

+
+## Migration Tool Options
+
+These are the options for converting a single PVC. **For more options**, see the [tool documentation](https://github.com/ceph/persistent-volume-migrator), for example to convert all PVCs automatically that belong to the same storage class.


Suggested change

These are the options for converting a single PVC. **For more options**, see the [tool documentation](https://github.com/ceph/persistent-volume-migrator), for example to convert all PVCs automatically that belong to the same storage class.

These are the options for converting a single PVC. For more options, see the [tool documentation](https://github.com/ceph/persistent-volume-migrator), for example to convert all PVCs automatically that belong to the same storage class.

Why was this bold?

The thought was to get more eyes but yeah we can remove them too.

Documentation/flex-to-csi-migration.md

mergify · 2021-11-30T03:10:39Z

This pull request has merge conflicts that must be resolved before it can be merged. @subhamkrai please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

mergify · 2021-11-30T03:11:43Z

This pull request has merge conflicts that must be resolved before it can be merged. @subhamkrai please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

mergify · 2021-11-30T03:11:44Z

Hi @subhamkrai, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

subhamkrai · 2021-11-30T03:27:29Z

I tried to move this PR from master to release-1.7 branch...messed in between but looks good now 😄

subhamkrai · 2021-11-30T03:28:47Z

Hi @subhamkrai, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

Yes, this is intentional.

Documentation/flex-to-csi-migration.md

travisn

My test of the conversion worked! just a few small suggestions in the doc...

My test consisted of creating flex volumes for mysql and wordpress example app pods, then converting them with these commands:

kubectl scale --replicas=0 deploy/wordpress-mysql
kubectl scale --replicas=0 deploy/wordpress
# connect to the migrator pod
pv-migrator --pvc=mysql-pv-claim --pvc-ns=default --destination-sc=rook-ceph-block-csi 
pv-migrator --pvc=wp-pv-claim --pvc-ns=default --destination-sc=rook-ceph-block-csi 
# disconnect from the migrator pod
kubectl scale --replicas=1 deploy/wordpress-mysql
kubectl scale --replicas=1 deploy/wordpress

Documentation/flex-to-csi-migration.md

travisn · 2021-12-02T00:05:46Z

Documentation/flex-to-csi-migration.md

+I1125 07:56:26.504578      63 log.go:34] waiting for PV pvc-30a01887-8821-4baf-835c-16a7e55ba7f0 in state &PersistentVolumeStatus{Phase:Bound,Message:,Reason:,} to be deleted (0 seconds elapsed)
+I1125 07:56:26.702921      63 log.go:34] deleted persistent volume pvc-30a01887-8821-4baf-835c-16a7e55ba7f0
+I1125 07:56:26.702944      63 log.go:34] successfully migrated pvc rbd-pvc
+I1125 07:56:26.703335      63 log.go:34] Successfully migrated all the PVCs to CSI


If only one PVC is being migrated, the tool should skip printing this line, it was confusing.

Suggested change

I1125 07:56:26.703335 63 log.go:34] Successfully migrated all the PVCs to CSI

this I'll need to change in tool side first. will open PR

We need to log something after successful migration. How about this

Successfully migrated flex PVCs to CSI

Migration done successfully

The message for individual PVC names seems sufficient. Or instead of saying "all" PVCs, how about printing the number of PVCs converted?

Documentation/flex-to-csi-migration.md

subhamkrai · 2021-12-02T04:50:11Z

My test of the conversion worked! just a few small suggestions in the doc...

My test consisted of creating flex volumes for mysql and wordpress example app pods, then converting them with these commands:
kubectl scale --replicas=0 deploy/wordpress-mysql
kubectl scale --replicas=0 deploy/wordpress
# connect to the migrator pod
pv-migrator --pvc=mysql-pv-claim --pvc-ns=default --destination-sc=rook-ceph-block-csi 
pv-migrator --pvc=wp-pv-claim --pvc-ns=default --destination-sc=rook-ceph-block-csi 
# disconnect from the migrator pod
kubectl scale --replicas=1 deploy/wordpress-mysql
kubectl scale --replicas=1 deploy/wordpress

Good to know it is working as expected!

Adding guide doc for migrating rbd flexvolume to ceph-csi. Signed-off-by: subhamkrai <srai@redhat.com>

Missed few nits of flex-migrator,doing it here as discussed. Signed-off-by: subhamkrai <srai@redhat.com>

travisn · 2021-12-02T15:02:33Z

Documentation/flex-to-csi-migration.md

+I1125 07:56:26.504578      63 log.go:34] waiting for PV pvc-30a01887-8821-4baf-835c-16a7e55ba7f0 in state &PersistentVolumeStatus{Phase:Bound,Message:,Reason:,} to be deleted (0 seconds elapsed)
+I1125 07:56:26.702921      63 log.go:34] deleted persistent volume pvc-30a01887-8821-4baf-835c-16a7e55ba7f0
+I1125 07:56:26.702944      63 log.go:34] successfully migrated pvc rbd-pvc
+I1125 07:56:26.703335      63 log.go:34] Successfully migrated all the PVCs to CSI


The message for individual PVC names seems sufficient. Or instead of saying "all" PVCs, how about printing the number of PVCs converted?

subhamkrai added the skip-ci label Nov 22, 2021

subhamkrai force-pushed the add-flex-doc branch from edac328 to 4c6d328 Compare November 22, 2021 10:44

subhamkrai changed the title ~~doc: add guide doc for flex migration~~ docs: add guide doc for flex migration Nov 22, 2021

subhamkrai force-pushed the add-flex-doc branch 2 times, most recently from 2b4da81 to e6c3a7d Compare November 22, 2021 12:58

subhamkrai requested review from BlaineEXE, leseb, Madhu-1 and travisn November 22, 2021 15:53

travisn requested changes Nov 22, 2021

View reviewed changes

subhamkrai force-pushed the add-flex-doc branch 3 times, most recently from c63a260 to b8292dc Compare November 23, 2021 08:15

travisn requested changes Nov 23, 2021

View reviewed changes

travisn mentioned this pull request Nov 23, 2021

rook-ceph-agent CrashLookBackOff on newly joined node -- container log shows help usage? #9231

Closed

subhamkrai force-pushed the add-flex-doc branch 2 times, most recently from a4b5567 to 38305fe Compare November 24, 2021 10:21

travisn requested changes Nov 24, 2021

View reviewed changes

subhamkrai force-pushed the add-flex-doc branch 2 times, most recently from a23c524 to 6022b0c Compare November 25, 2021 11:36

leseb requested changes Nov 25, 2021

View reviewed changes

subhamkrai requested a review from Yuggupta27 November 29, 2021 05:51

subhamkrai force-pushed the add-flex-doc branch 2 times, most recently from 2ce58ae to 7aaaed3 Compare November 29, 2021 06:55

subhamkrai marked this pull request as ready for review November 29, 2021 11:21

subhamkrai requested review from travisn and leseb November 29, 2021 11:22

leseb requested changes Nov 29, 2021

View reviewed changes

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

subhamkrai force-pushed the add-flex-doc branch from 7aaaed3 to 3deeb79 Compare November 29, 2021 13:42

leseb approved these changes Nov 29, 2021

View reviewed changes

travisn reviewed Nov 29, 2021

View reviewed changes

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

subhamkrai force-pushed the add-flex-doc branch from 3deeb79 to b809a7c Compare November 30, 2021 03:10

subhamkrai force-pushed the add-flex-doc branch from b809a7c to 3deeb79 Compare November 30, 2021 03:11

subhamkrai changed the base branch from master to release-1.7 November 30, 2021 03:11

subhamkrai closed this Nov 30, 2021

subhamkrai force-pushed the add-flex-doc branch from 3deeb79 to a9cda1e Compare November 30, 2021 03:13

subhamkrai reopened this Nov 30, 2021

travisn requested changes Nov 30, 2021

View reviewed changes

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

subhamkrai force-pushed the add-flex-doc branch from 4917b7b to 5e81b88 Compare December 1, 2021 09:17

subhamkrai requested a review from travisn December 1, 2021 09:18

travisn requested changes Dec 2, 2021

View reviewed changes

Yuggupta27 requested changes Dec 2, 2021

View reviewed changes

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

Documentation/flex-to-csi-migration.md Outdated Show resolved Hide resolved

subhamkrai force-pushed the add-flex-doc branch from 5e81b88 to f2f9f58 Compare December 2, 2021 05:04

subhamkrai added 2 commits December 2, 2021 10:41

docs: add guide doc for flex migration

aee981b

Adding guide doc for migrating rbd flexvolume to ceph-csi. Signed-off-by: subhamkrai <srai@redhat.com>

docs: last nits of flex-migrator yaml

bd55c7e

Missed few nits of flex-migrator,doing it here as discussed. Signed-off-by: subhamkrai <srai@redhat.com>

subhamkrai force-pushed the add-flex-doc branch from f2f9f58 to bd55c7e Compare December 2, 2021 05:11

subhamkrai requested review from travisn and Yuggupta27 December 2, 2021 05:21

Yuggupta27 approved these changes Dec 2, 2021

View reviewed changes

travisn approved these changes Dec 2, 2021

View reviewed changes

travisn merged commit a899d96 into rook:release-1.7 Dec 2, 2021

subhamkrai linked an issue Dec 2, 2021 that may be closed by this pull request

Migration procedure from flexvolume to ceph-csi #4043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add guide doc for flex migration #9222

docs: add guide doc for flex migration #9222

subhamkrai commented Nov 22, 2021 •

edited

subhamkrai commented Nov 22, 2021

travisn Nov 24, 2021

travisn Nov 24, 2021

travisn Nov 24, 2021

subhamkrai Nov 25, 2021

leseb Nov 25, 2021

subhamkrai Nov 29, 2021 •

edited

mergify bot commented Nov 30, 2021

mergify bot commented Nov 30, 2021

mergify bot commented Nov 30, 2021

subhamkrai commented Nov 30, 2021

subhamkrai commented Nov 30, 2021

travisn left a comment

travisn Dec 2, 2021

subhamkrai Dec 2, 2021

subhamkrai Dec 2, 2021

travisn Dec 2, 2021

subhamkrai commented Dec 2, 2021

travisn Dec 2, 2021


		## Migration Tool Options

		These are the options for converting a single PVC. For more options, see the [tool documentation](https://github.com/ceph/persistent-volume-migrator), for example to convert all PVCs automatically that belong to the same storage class.

docs: add guide doc for flex migration #9222

docs: add guide doc for flex migration #9222

Conversation

subhamkrai commented Nov 22, 2021 • edited

subhamkrai commented Nov 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

subhamkrai Nov 29, 2021 • edited

Choose a reason for hiding this comment

mergify bot commented Nov 30, 2021

mergify bot commented Nov 30, 2021

mergify bot commented Nov 30, 2021

subhamkrai commented Nov 30, 2021

subhamkrai commented Nov 30, 2021

travisn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

subhamkrai commented Dec 2, 2021

Choose a reason for hiding this comment

subhamkrai commented Nov 22, 2021 •

edited

subhamkrai Nov 29, 2021 •

edited