helm: allow further configurability of ingress version (manual backport) #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHellier
force-pushed
the
cherrypick-pr-9176
branch
2 times, most recently
from
2322a17
to
90394c6
Compare
|
@travisn I've just copied the helm code over, as even resolving the commits and trying to get the tests working wasn't proving very fruitful as the orchestration has changed so significantly. |
TomHellier
changed the title
|
Hi @TomHellier, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches. |
It's alright. |
leseb
requested changes
Nov 29, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602) Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
force-pushed
the
cherrypick-pr-9176
branch
from
88a46e5
to
80b63bd
Compare
|
@leseb refixed conflicts |
leseb
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingress api version changed when it went to v1, and this has caused some upheaval
throughout the kubernetes ecosystem. This commit uses a common method of deciding which
ingress api to use, and allows the optional override of the kubernetes version
presented to helm using the helm build-in capabilities.
also add an ingress into the helm integration tests so any regressions to how ingresses
are handled in the future are caught easier.
Closes #9174
Signed-off-by: Tom Hellier me@tomhellier.com
(cherry picked from commit ba44602)
Which issue is resolved by this Pull Request:
Resolves #9232