Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: fix rgw ceph config #9249

Merged
merged 1 commit into from Nov 25, 2021
Merged

Conversation

olivierbouffet
Copy link
Contributor

use Zone and ZoneGroup instead of storename for rgw_zone and rgw_zonegroup flags

Signed-off-by: Olivier Bouffet olivier.bouffet@infomaniak.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #9248

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

use Zone and ZoneGroup instead of storename for rgw_zone and rgw_zonegroup

Signed-off-by: Olivier Bouffet <olivier.bouffet@infomaniak.com>
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, not sure why we were assuming all CRDs have the same name. I followed the code path and based on https://github.com/rook/rook/blob/master/pkg/operator/ceph/object/controller.go#L507 this should not break the non-multisite deployments.

@leseb leseb merged commit fbe47e4 into rook:release-1.7 Nov 25, 2021
@leseb
Copy link
Member

leseb commented Nov 25, 2021

I completely missed that the PR was against release-1.7 branch, my bad but next time please send a PR to the master branch first, and then we will backport it... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants