Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs-mirror: various fixes for random bootstrap peer import errors #9264

Merged
merged 3 commits into from Nov 29, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Nov 26, 2021

Description of your changes:

cephfs-mirror: try to mitigate peer import error
Some users have reported issues while adding the token, this is not
always reproducible so perhaps it's a typo when importing the token and
adding trailing spaces.

core: add the ability to execute ceph commands with a combined output
Sometimes Ceph uses a different standard output to return errors or
merges standard error to standard out. So let's allow some commands to
return both in the output.

cephfs-mirror: use the combined output to possibly catch peer import error
By adding combined output to the executor we might be able to fetch more
error messages.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #9151

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Some users have reported issues while adding the token, this is not
always reproducable so perhaps it's a typo when importing the token and
adding trailing spaces.

Closes: rook#9151
Signed-off-by: Sébastien Han <seb@redhat.com>
Sometimes Ceph uses a different standard output to return errors or
merges standard error to standard out. So let's allow some commands to
return both in the output.

Signed-off-by: Sébastien Han <seb@redhat.com>
By adding a combined output to the executor we might be able to fetch more
error messages.

Signed-off-by: Sébastien Han <seb@redhat.com>
@travisn
Copy link
Member

travisn commented Nov 29, 2021

LGTM, except the linter doesn't seem to like the dash in the commit prefix.

@leseb leseb merged commit bf662ec into rook:master Nov 29, 2021
@leseb leseb deleted the fix-9151 branch November 29, 2021 14:45
leseb added a commit that referenced this pull request Nov 29, 2021
cephfs-mirror: various fixes for random bootstrap peer import errors (backport #9264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CephFS mirroring: Importing Bootsrap peer secret sometimes fail with Status 22
2 participants