Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add pv-migrator binary to rook image in 1.7.x branch #9274

Merged
merged 2 commits into from Dec 1, 2021
Merged

build: add pv-migrator binary to rook image in 1.7.x branch #9274

merged 2 commits into from Dec 1, 2021

Conversation

subhamkrai
Copy link
Contributor

  • Adding add pv-migrator binary to rook image directly
    in 1.7.x branch as discussed.

  • Adding migrator.yaml file which will required
    to run migrator pod.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify
Copy link

mergify bot commented Nov 30, 2021

Hi @subhamkrai, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

subhamkrai
subhamkrai commented Nov 30, 2021
View reviewed changes
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated
dnsPolicy: ClusterFirstWithHostNet
containers:
- name: rook-ceph-migrator
image: rook/ceph:v1.7.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll change accordingly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and set it to the latest release, then we have a PR to replace all the versions when we release.

Suggested change
image: rook/ceph:v1.7.x
image: rook/ceph:v1.7.8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@subhamkrai
Copy link
Contributor Author

Hi @subhamkrai, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

Yes, this has been already discussed we want to get this PR directly in 1.7 release branch.

@subhamkrai subhamkrai added the do-not-merge DO NOT MERGE :) label Nov 30, 2021
@subhamkrai
Copy link
Contributor Author

added label dnm I want to test more... I have tested in the master branch want to test in 1.7 branch

leseb
leseb requested changes Nov 30, 2021
View reviewed changes
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
images/ceph/Dockerfile
@@ -20,7 +20,11 @@ ARG TINI_VERSION

# Run tini as PID 1 and avoid signal handling issues
RUN curl --fail -sSL -o /tini https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${ARCH} && \
chmod +x /tini
chmod +x /tini && \
curl -LJO https://github.com/ceph/persistent-volume-migrator/releases/download/v0.1.0-alpha/pv-migrator && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to build for different architectures, do we? This will fail on arm64 right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a conditional for amd64 in the dockerfile? Or for now we just pull an invalid image for arm64, then fix it later if needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, going with what we have to get the testing going...

images/ceph/Dockerfile Outdated Show resolved Hide resolved
images/ceph/Dockerfile Outdated Show resolved Hide resolved
@subhamkrai subhamkrai force-pushed the add-binary branch 4 times, most recently from ea4bed7 to ca95b3e Compare November 30, 2021 13:12
travisn
travisn requested changes Nov 30, 2021
View reviewed changes
cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated
dnsPolicy: ClusterFirstWithHostNet
containers:
- name: rook-ceph-migrator
image: rook/ceph:v1.7.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and set it to the latest release, then we have a PR to replace all the versions when we release.

Suggested change
image: rook/ceph:v1.7.x
image: rook/ceph:v1.7.8

cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Outdated Show resolved Hide resolved
@travisn travisn mentioned this pull request Nov 30, 2021
Merged
10 tasks
@subhamkrai
build: add pv-migrator binary to rook image in 1.7.8 branch
5f95e78 
Adding  add pv-migrator binary to rook image directly
in 1.7.8 branch as discussed.

Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai
core: adding migrator.yaml for pv-migrator tool
91a9ba6 
Adding migrator.yaml file which will required
to run migrator pod.

Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai
Copy link
Contributor Author

FWIW, I tested this here ceph/persistent-volume-migrator#38 using my custom build.

travisn
travisn approved these changes Dec 1, 2021
View reviewed changes
images/ceph/Dockerfile
@@ -20,7 +20,11 @@ ARG TINI_VERSION

# Run tini as PID 1 and avoid signal handling issues
RUN curl --fail -sSL -o /tini https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${ARCH} && \
chmod +x /tini
chmod +x /tini && \
curl -LJO https://github.com/ceph/persistent-volume-migrator/releases/download/v0.1.0-alpha/pv-migrator && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, going with what we have to get the testing going...

leseb
leseb requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit

cluster/examples/kubernetes/ceph/pv-migrator/migrator.yaml Show resolved Hide resolved
@leseb leseb removed the do-not-merge DO NOT MERGE :) label Dec 1, 2021
leseb
leseb approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward and address the last nit in the doc PR.

@leseb leseb merged commit f95602b into rook:release-1.7 Dec 1, 2021
@subhamkrai subhamkrai deleted the add-binary branch December 2, 2021 05:02
@subhamkrai
Copy link
Contributor Author

Let's move forward and address the last nit in the doc PR.

f2f9f58

@subhamkrai subhamkrai linked an issue Dec 2, 2021 that may be closed by this pull request
Migration procedure from flexvolume to ceph-csi #4043
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration procedure from flexvolume to ceph-csi
3 participants
@subhamkrai @leseb @travisn