helm: Use a more explicit value for ingress for K8s 1.18 #9280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHellier
force-pushed
the
test-helm-on-multiple-versions
branch
from
f74050b
to
cf5601f
Compare
TomHellier
changed the title
|
@TomHellier Thanks for the fix and verifying on all the K8s versions! How about if you revert the commit that tests on more k8s versions, then we can get this merged. |
The networking.k8s.io/v1 api defines the backend differently to networking.k8s.io/v1beta1 and extensions/v1beta1 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
force-pushed
the
test-helm-on-multiple-versions
branch
from
c941d4d
to
2ca93e5
Compare
travisn
approved these changes
Dec 1, 2021
Already done I see with #9293. :) |
travisn
changed the title
BlaineEXE
approved these changes
Dec 2, 2021
travisn
added a commit
that referenced
this pull request
Dec 2, 2021
helm: Use a more explicit value for ingress (backport #9280)
mergify bot
added a commit
that referenced
this pull request
Dec 2, 2021
helm: Use a more explicit value for ingress for K8s 1.18 (backport #9280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Updating minor versions of kubernetes test environments, and running helm charts against all supported environments.
Which issue is resolved by this Pull Request:
Resolves #9174
Checklist:
make codegen) has been run to update object specifications, if necessary.