Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CephFS dataPools unordered and unnamed #9295

Closed
degorenko opened this issue Dec 2, 2021 · 1 comment
Closed

CephFS dataPools unordered and unnamed #9295

degorenko opened this issue Dec 2, 2021 · 1 comment
Labels

Comments

@degorenko
Copy link
Contributor

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
Current implementation of CephFilesystem spec allows to specify multiple dataPools as an array list, but they don't have strong names and created based on index in array. Such behaviour doesn't allow to use static names or relay on already created names, since any newly added dataPool should be created after manual removal of previously added pool or added to the end of list. As an option we can add dataPools based on predefined pool name. Thus, usage of such pools is predictable and storage classes can be created with using static pool name.

What is use case behind this feature:
When env has a lot of applications, which are using CephFS, predictable pool names allow strong and reliable usage of PV/Storage classes. Also, changing number of pools specified in spec will not lead to additional manual actions like pool removal, crush map update and so on. This can be done manually in any time if case of need, regardless of spec changes.

Environment:

degorenko added a commit to degorenko/rook that referenced this issue Dec 2, 2021
Add an ability to specify CephFS dataPools as a map with a predefined
pool name.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 2, 2021
Add an ability to specify CephFS dataPools as a map with a predefined
pool name.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 2, 2021
Add an ability to specify CephFS dataPools as a map with a predefined
pool name.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 2, 2021
Add an ability to specify CephFS dataPools as a map with a predefined
pool name.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 7, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 7, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 7, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 8, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 10, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 10, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 11, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
degorenko added a commit to degorenko/rook that referenced this issue Dec 14, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
mergify bot pushed a commit that referenced this issue Dec 14, 2021
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: #9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
(cherry picked from commit 3ff681e)
@travisn
Copy link
Member

travisn commented Dec 14, 2021

This was resolved by #9296 and will be included in v1.8.1

@travisn travisn closed this as completed Dec 14, 2021
parth-gr pushed a commit to parth-gr/rook that referenced this issue Feb 22, 2022
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
parth-gr pushed a commit to parth-gr/rook that referenced this issue Feb 22, 2022
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants