Truncate job name of the osd prepare job further to avoid pod generation failure on K8s 1.22 #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
reviewed
Dec 6, 2021
pkg/operator/k8sutil/k8sutil.go
Outdated
|
|
||
| // truncateNodeName takes the max length desired for a string and hashes the value if needed to shorten it. | ||
| func truncateNodeName(format, nodeName string, maxLength int) string { | ||
| if len(nodeName)+len(fmt.Sprintf(format, "")) > maxLength { | ||
| hashed := Hash(nodeName) | ||
| logger.Infof("format and nodeName longer than %d chars, nodeName %s will be %s", validation.DNS1035LabelMaxLength, nodeName, hashed) |
There was a problem hiding this comment.
Should the log info message be updated too with maxLength instead of validation.DNS1035LabelMaxLength?
In K8s 1.22 there is a bug in the job name generation that the job name is truncated an additional 10 characters. This can cause an issue in the generated pod name if it then ends in a non-alphanumeric character. In that case, we more aggressively generate a hashed job name. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The generation of a long node name in the integration tests was being done based on the k8s version. In the past, older K8s versions did not support the changing name. Now it's more maintainable if we generate the long name depending on the test suite. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
truncate-job-name
branch
from
bc8314b
to
9d2aa1f
Compare
leseb
approved these changes
Dec 7, 2021
|
This pull request has merge conflicts that must be resolved before it can be merged. @travisn please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork |
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2021
Truncate job name of the osd prepare job further to avoid pod generation failure on K8s 1.22 (backport #9312)
travisn
added a commit
that referenced
this pull request
Dec 7, 2021
Truncate job name of the osd prepare job further to avoid pod generation failure on K8s 1.22 (backport #9312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #9294
Checklist:
make codegen) has been run to update object specifications, if necessary.