object: fix handling for notifications for OBC

[thotz]

Current approach is to delete all the existing notifcations from bucket
and re-add the notification from the labels.

Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
• Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
• Reviewed the developer guide on Submitting a Pull Request
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.
• Pending release notes updated with breaking and/or notable changes, if necessary.
• Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
• Code generation (make codegen) has been run to update object specifications, if necessary.

[yuvalif]

looks good!
could you please add a unit tests that covers the new code in the controller?
should be possible by mocking the GetNotifications() and DeleteNotification()call for a specific test, so that it verifies that the notifications that should be deleted are indeed deleted

[yuvalif]

see comment: #9365 (comment)

unit tests should cover the case where some notifications are added some deleted and some unchanged.
this could be verified by mocking the "get", "create" and "delete" functions for this specific test.
the verification can make sure that each notifications is handled correctly (and not only that the functions are invoked)

[thotz]

see comment: #9365 (comment)

unit tests should cover the case where some notifications are added some deleted and some unchanged. this could be verified by mocking the "get", "create" and "delete" functions for this specific test. the verification can make sure that each notifications is handled correctly (and not only that the functions are invoked)

Done

[BlaineEXE]

Looks good. I think all test cases are covered. But I do think we should be verifying correctness of the important aspects of the create/delete calls, not just that they are called.

Also, all logger.{Error,Warning,Info,Debug} messages should include namespaced names for context because a user may create the same name for a resource in multiple namespaces.