mgr: run the watch side car config on /etc/ceph #9386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking: |
Good point, I need to check and merge, if not done already. |
For now, we must run the container with UID 0 and privileged for multiple reasons: * the rook binary writes ceph config to /var/lib/rook which is owned by root * it's difficult to use /etc/ceph since it will conflict with the rook-ceph-override configmap AND is also owned by root since it's a mounted configmap. * using /etc/ceph might be possible but has other issues with rook's exec package since the ceph config is built from /var/lib/rook Closes: rook#9385 Signed-off-by: Sébastien Han <seb@redhat.com>
The context was not initialized and thus the configmap fetch will fail with a nil pointer. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
mgr-active-side-car-permissions
branch
from
d370654
to
892c9a2
Compare
travisn
reviewed
Dec 13, 2021
travisn
approved these changes
Dec 15, 2021
mergify bot
added a commit
that referenced
this pull request
Dec 15, 2021
mgr: run the watch side car config on /etc/ceph (backport #9386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We don't need to use /var/lib/rook for the ceph config and keyring, so
let's use /etc/ceph which has the right permissions too. Also, we need
to run with the ceph user since the rook image defaults to the "rook"
user.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #9385
Checklist:
make codegen) has been run to update object specifications, if necessary.