security: use correct osd tags for restricted caps with external cluster script #9410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-gr
reviewed
Dec 13, 2021
| @@ -168,7 +168,7 @@ def gen_arg_parser(cls, args_to_parse=None): | |||
| common_group.add_argument("--rgw-pool-prefix", default="", | |||
| help="RGW Pool prefix") | |||
| common_group.add_argument("--restricted-auth-permission", default=False, | |||
| help="Restricted cephCSIKeyrings auth permissions to specific pools and cluster. Mandatory flags that are needed to be set --cephfs-metadata-pool-name, --cephfs-data-pool-name and --rbd-data-pool-name. Note: Restricting the users per pool and per cluster will require to create new users and new secrets for that users.") | |||
| help="Restricted cephCSIKeyrings auth permissions to specific pools and cluster. Mandatory flag that needes to be set is --rbd-data-pool-name. Note: Restricting the users per pool and per cluster will require to create new users and new secrets for that users.") | |||
There was a problem hiding this comment.
plz mention --cephfs-filesystem-name flag that would be mandatory to be set.
| cmd_json = {"prefix": "auth get-or-create", | ||
| "entity": entity, | ||
| "caps": ["mon", "allow r", "mgr", "allow rw", | ||
| "osd", "allow rw tag cephfs metadata={}".format(metadata_pool)], | ||
| "osd", "allow rw tag cephfs metadata={}".format(cephfs_filesystem)], |
There was a problem hiding this comment.
And can you also verify once if the PVC created can bind to the deployment
There was a problem hiding this comment.
I can confirm this works. I created a new deployment with a new PVC and the volume gets successfully mounted inside the container
parth-gr
requested changes
Dec 13, 2021
| @@ -1037,7 +1037,7 @@ def test_method_create_cephCSIKeyring_cephFSProvisioner(self): | |||
| csiKeyring = self.rjObj.create_cephCSIKeyring_cephFSProvisioner() | |||
| print("cephCSIKeyring without restricting it to a metadata pool. {}".format(csiKeyring)) | |||
| self.rjObj._arg_parser.restricted_auth_permission = True | |||
| self.rjObj._arg_parser.cephfs_metadata_pool_name = "myfs-metadata" | |||
| self.rjObj._arg_parser.cephfs_fs_name = "myfs" | |||
There was a problem hiding this comment.
this would be like self.rjObj._arg_parser.cephfs_filesystem_name = "myfs"
The create-external-cluster-resources.py with --create-external-cluster-resources set to true sets a wrong osd application tag. It should use the fs name and not the fs pools. Closes: rook#9227 Signed-off-by: Lennart Hagemann <lennart.hagemann@continum.net>
CO-lhageman
force-pushed
the
restricted-cephfs-caps
branch
from
3a76a8f
to
7507790
Compare
|
@parth-gr I addressed the comments you made, can you confirm? |
leseb
approved these changes
Dec 13, 2021
mergify bot
added a commit
that referenced
this pull request
Dec 13, 2021
security: use correct osd tags for restricted caps with external cluster script (backport #9410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The create-external-cluster-resources.py with
--create-external-cluster-resources set to true
sets a wrong osd application tag. It should use
the fs name and not the fs pools.
Which issue is resolved by this Pull Request:
Resolves #9227
Signed-off-by: Lennart Hagemann lennart.hagemann@continum.net
Checklist:
make codegen) has been run to update object specifications, if necessary.