core: disallow multiple clusters in the same namespace #9457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's use debug not to clutter logs. Signed-off-by: Sébastien Han <seb@redhat.com>
Rook does not support running multiple clusters in the same namespace, so the operator should not reconcile if a new cluster is added. The scenario where a cluster is added while the operator is down is also handled. CR updates are also handled. When the operator detects more than one cluster it will refuse to reconcile the CephCluster, and child CRDs will block too until the operator is ready. The user must remove one of the clusters before can continue to perform any reconcile. Closes: rook#9452 Signed-off-by: Sébastien Han <seb@redhat.com>
travisn
reviewed
Dec 17, 2021
| @@ -41,6 +44,10 @@ func predicateController() predicate.Funcs { | |||
|
|
|||
| // If a Ceph Cluster is created we want to reconcile the csi driver | |||
| if cephCluster, ok := e.Object.(*cephv1.CephCluster); ok { | |||
| // If there are more than one ceph cluster in the same namespace do not reconcile | |||
| if controller.DuplicateCephClusters(ctx, c, e.Object, false) { | |||
There was a problem hiding this comment.
Do we really need to skip reconcile in the csi and obc controllers in this case? It's a rare enough error that it doesn't seem necessary to check here and just keep these other controllers simple.
There was a problem hiding this comment.
If we don't check, the logs will be a bit cluttered and users might skip the useful information. CSI and OBC controllers will reconcile and hide the message:
2021-12-17 09:27:02.826962 E | ceph-spec: found more than one ceph cluster in namespace "rook-ceph". not reconciling. only one ceph cluster per namespace.
2021-12-17 09:27:02.826989 E | ceph-spec: found ceph cluster "lesebb" in namespace "rook-ceph"
2021-12-17 09:27:02.826994 E | ceph-spec: found ceph cluster "rook-ceph" in namespace "rook-ceph"
travisn
approved these changes
Dec 20, 2021
mergify bot
added a commit
that referenced
this pull request
Dec 20, 2021
core: disallow multiple clusters in the same namespace (backport #9457)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Rook does not support running multiple clusters in the same namespace,
so the operator should not reconcile if a new cluster is added.
The scenario where a cluster is added while the operator is down is also
handled. CR updates are also handled.
When the operator detects more than one cluster it will refuse to
reconcile the CephCluster, and child CRDs will block too until the
operator is ready.
The user must remove one of the clusters before can continue to perform
any reconcile.
Closes: #9452
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #9452
Checklist:
make codegen) has been run to update object specifications, if necessary.