Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: run discover daemonset as root uid #9512

Merged
merged 1 commit into from Jan 4, 2022
Merged

core: run discover daemonset as root uid #9512

merged 1 commit into from Jan 4, 2022

Conversation

leseb
Copy link
Member

@leseb leseb commented Jan 3, 2022

Description of your changes:

So that the tool inside the container has the permission to run
correctly, e.g: sgdisk.

Clsoes: #9493
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #9493

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
core: run discover daemonset as root uid
dd67b86 
So that the tool inside the container has the permission to run
correctly, e.g: sgdisk.

Clsoes: rook#9493
Signed-off-by: Sébastien Han <seb@redhat.com>
This was linked to issues Jan 3, 2022
Rook discover daemon cannot see any disks #9483
Closed
the discovery service did not discover my disk and ignored it #9501
Closed
subhamkrai
subhamkrai approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leseb leseb requested a review from travisn January 4, 2022 16:43
@travisn travisn merged commit ee5ce2e into rook:master Jan 4, 2022
@mergify mergify bot mentioned this pull request Jan 4, 2022
Merged
@leseb leseb deleted the fix-9493 branch January 4, 2022 16:58
BlaineEXE added a commit that referenced this pull request Jan 4, 2022
@BlaineEXE
Merge pull request #9518 from rook/mergify/bp/release-1.8/pr-9512
a5f8e42 
core: run discover daemonset as root uid (backport #9512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@subhamkrai subhamkrai subhamkrai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@leseb @travisn @subhamkrai