Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use the same csv name for all platforms #9515

Merged
merged 1 commit into from Jan 4, 2022
Merged

build: use the same csv name for all platforms #9515

merged 1 commit into from Jan 4, 2022

Conversation

leseb
Copy link
Member

@leseb leseb commented Jan 4, 2022

Recently with the directory renaming to "deploy/olm" the CSV name
changed from "ceph" to "olm". Now we are using the same "rook-ceph" name
regardless of the platform.

Signed-off-by: Sébastien Han seb@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
build: use the same csv name for all platforms
7cf9285 
Recently with the directory renaming to "deploy/olm" the CSV name
changed from "ceph" to "olm". Now we are using the same "rook-ceph" name
regardless of the platform.

Signed-off-by: Sébastien Han <seb@redhat.com>
@travisn travisn merged commit 9f841ed into rook:master Jan 4, 2022
@mergify mergify bot mentioned this pull request Jan 4, 2022
Merged
@leseb leseb deleted the fix-csv-name-ocp branch January 4, 2022 16:42
mergify bot added a commit that referenced this pull request Jan 4, 2022
@mergify
Merge pull request #9517 from rook/mergify/bp/release-1.8/pr-9515
295df75 
build: use the same csv name for all platforms (backport #9515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn