Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: update to latest lib-bucket-provisioner #9529

Conversation

BlaineEXE
Copy link
Member

The latest lib-bucket-provisioner has a corner case fix for a bucket
with generateName equal to exactly 27 chars, which will result in an
ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes.

See:
kube-object-storage/lib-bucket-provisioner#220

Signed-off-by: Blaine Gardner blaine.gardner@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

The latest lib-bucket-provisioner has a corner case fix for a bucket
with `generateName` equal to exactly 27 chars, which will result in an
ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes.

See:
kube-object-storage/lib-bucket-provisioner#220

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@BlaineEXE BlaineEXE added this to In progress in v1.8 via automation Jan 5, 2022
@satoru-takeuchi satoru-takeuchi merged commit b69719a into rook:master Jan 5, 2022
v1.8 automation moved this from In progress to Done Jan 5, 2022
satoru-takeuchi added a commit that referenced this pull request Jan 6, 2022
object: update to latest lib-bucket-provisioner (backport #9529)
@BlaineEXE BlaineEXE deleted the update-to-latest-lib-bucket-provisioner branch January 11, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.8
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants