Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: fix startup probe #9533

Merged
merged 1 commit into from Jan 6, 2022
Merged

rgw: fix startup probe #9533

merged 1 commit into from Jan 6, 2022

Conversation

satoru-takeuchi
Copy link
Member

Description of your changes:

It's better to set the same handler to startupProbe as livenessProbe. Otherwise, we might hit the following problem.

#6304

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@satoru-takeuchi
rgw: fix startup probe
af88b50 
It's better to set the same handler to startupProbe as livenessProbe.
Otherwise, we might hit the following problem.

rook#6304

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
travisn
travisn approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to discuss with Blaine, but let's get this in for now.

@travisn travisn merged commit 33381fe into rook:master Jan 6, 2022
@mergify mergify bot mentioned this pull request Jan 6, 2022
Merged
mergify bot added a commit that referenced this pull request Jan 6, 2022
@mergify
Merge pull request #9537 from rook/mergify/bp/release-1.8/pr-9533
43d5b29 
rgw: fix startup probe (backport #9533)
@satoru-takeuchi satoru-takeuchi deleted the core-rgw-fix-startup-probe branch June 8, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@leseb leseb Awaiting requested review from leseb

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
bug ceph-rgw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@satoru-takeuchi @travisn