From 10a114a45a1220ea30de7b18e923fb4243201632 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Mon, 8 Nov 2021 08:48:35 +0100 Subject: [PATCH] core: fail if config dir creation fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the operator fails to create the operator's configuration directory then we should fail the Operator. Signed-off-by: Sébastien Han --- pkg/daemon/ceph/client/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/daemon/ceph/client/config.go b/pkg/daemon/ceph/client/config.go index 2bf2aa932b77..da2f41494131 100644 --- a/pkg/daemon/ceph/client/config.go +++ b/pkg/daemon/ceph/client/config.go @@ -110,7 +110,7 @@ func generateConfigFile(context *clusterd.Context, clusterInfo *ClusterInfo, pat // create the config directory if err := os.MkdirAll(pathRoot, 0744); err != nil { - logger.Warningf("failed to create config directory at %q. %v", pathRoot, err) + return "", errors.Wrapf(err, "failed to create config directory at %q", pathRoot) } configFile, err := createGlobalConfigFileSection(context, clusterInfo, globalConfig)